Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set the asyncio default before deprecation #1199

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

dimaqq
Copy link
Contributor

@dimaqq dimaqq commented Nov 19, 2024

fixes #1192, hopefully

@dimaqq dimaqq force-pushed the chore-pytest-ini-option branch from 59b9bad to 28f12ff Compare November 19, 2024 07:35
@dimaqq dimaqq marked this pull request as ready for review November 20, 2024 00:24
Copy link
Contributor

@james-garner-canonical james-garner-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass! Coincidence? I guess we'll see after rebasing.

@james-garner-canonical
Copy link
Contributor

I notice there's a pytest section in tox.ini, any interest or point in unifying this config at some point? (not a blocker)

[pytest]
markers =
    serial: mark a test that must run by itself
    wait_for_idle: mark a test that waits for the model to be idle
    bundle: mark a test that uses a bundle
asyncio_mode = auto
filterwarnings =
    ignore::DeprecationWarning:websockets

@dimaqq dimaqq force-pushed the chore-pytest-ini-option branch from 28f12ff to df4a1e0 Compare November 20, 2024 02:04
@dimaqq
Copy link
Contributor Author

dimaqq commented Nov 20, 2024

/merge

@jujubot jujubot merged commit 271657a into juju:main Nov 20, 2024
20 of 22 checks passed
@dimaqq dimaqq deleted the chore-pytest-ini-option branch November 22, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look into pytest-asyncio warnings
3 participants